Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for android platform #274

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Add support for android platform #274

merged 2 commits into from
Jun 14, 2022

Conversation

newsch
Copy link
Contributor

@newsch newsch commented Jun 2, 2022

tldr added android-specific commands under a new 'android' platform last year: tldr-pages/tldr#5462

I think I caught all uses of the platform types, but another pair of eyes would be much appreciated!

@newsch
Add support for android platform
4a5410f 
tldr added android-specific commands under a new 'android' platform
last year: <tldr-pages/tldr#5462>
niklasmohrin
niklasmohrin reviewed Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some remarks:

niklasmohrin
niklasmohrin approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@newsch
Copy link
Contributor Author

newsch commented Jun 14, 2022

Thank you! I use tealdeer almost every day :)

@niklasmohrin niklasmohrin requested a review from dbrgn June 14, 2022 20:53
@niklasmohrin niklasmohrin mentioned this pull request Jun 14, 2022
Closed
dbrgn
dbrgn approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM as well 🙂

@dbrgn dbrgn merged commit 543fa22 into tealdeer-rs:main Jun 14, 2022
@dbrgn dbrgn mentioned this pull request Jun 14, 2022
Closed
@niklasmohrin niklasmohrin mentioned this pull request Jun 14, 2022
Open
@newsch newsch deleted the android-platform branch June 14, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrgn dbrgn dbrgn approved these changes

@niklasmohrin niklasmohrin niklasmohrin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newsch @dbrgn @niklasmohrin