Create macOS release builds with bundled root certificates

[dbrgn]

As reported in #244, some users on macOS had problems with rustls-tls-native-roots. Since we did not find the root cause of this, we'll build macOS release builds with rustls-tls-webpki-roots instead.

I first tried to solve this issue with default features and conditional dependencies in Cargo.toml, but ultimately gave up and resorted to sed.

Fixes #244.

[niklasmohrin]

I think this works:

diff --git a/Cargo.toml b/Cargo.toml
index 6752a3b..1f8cf5c 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -26,7 +26,7 @@ atty = "0.2"
 clap = { version = "3", features = ["std", "derive", "suggestions", "color"], default-features = false }
 env_logger = { version = "0.9", optional = true }
 log = "0.4"
-reqwest = { version = "0.11.3", features = ["blocking", "rustls-tls", "rustls-tls-native-roots"], default-features = false }
+reqwest = { version = "0.11.3", features = ["blocking", "rustls-tls"], default-features = false }
 serde = "1.0.21"
 serde_derive = "1.0.21"
 toml = "0.5.1"
@@ -44,6 +44,9 @@ tempfile = "3.1.0"
 filetime = "0.2.10"
 
 [features]
+default = ["native-roots"]
+native-roots = ["reqwest/rustls-tls-native-roots"]
+webpki-roots = ["reqwest/rustls-tls-webpki-roots"]
 logging = ["env_logger"]
 
 [profile.release]
diff --git a/src/main.rs b/src/main.rs
index 216c349..4350f04 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -16,6 +16,11 @@
 #![allow(clippy::struct_excessive_bools)]
 #![allow(clippy::too_many_lines)]
 
+#[cfg(all(feature = "native-roots", feature = "webpki-roots"))]
+compile_error!(
+    "feature \"native-roots\" and feature \"webpki-roots\" cannot be enabled at the same time"
+);
+
 use std::{env, process};
 
 use app_dirs::AppInfo;

Check with cargo tree -e features -i reqwest --features webpki-roots --no-default-features

[dbrgn]

Updated! I also had to fix all usage of --all-features as well as adding an assertion that at least one of the two features is defined (otherwise updating will fail at runtime).