chore: download proper tldr archive #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create explicit CacheFreshness enum - Do not exit inside `check_cache` function, this prevents further actions if the cache isn't found
|
I see what you did to those commit IDs 😂 |
dbrgn
requested changes
Oct 16, 2021
dbrgn
added a commit
that referenced
this pull request
Oct 16, 2021
Download tldr pages from proper archive URL.
|
Merged in f7da0b0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the tldr client specifications, downloading https://tldr.sh/assets/tldr.zip is preferred over directly downloading an archive of the master branch.
To achieve this, I've replaced the flate2 crate with the zip crate, and have changed the download URL accordingly. Also, instead of wiping the entire cache dir, I've made
Cache::clear()only delete directories that are known to contain a tldr-pages archive, i.e.tldr-master(the old dir) andtldr-pages(the new dir). In the future, we could/should drop the part which deals with the old directory.This PR also includes changes from @dbrgn's cache refactoring branch.