Implement support for italics #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing, this looks good! 🚀 Could you add an integration test that checks that italic styling works (or enhance one of the styling tests to style something as italic too)? It should be as easy as picking something in the test config.toml to be rendered as italic and updating the expected results |
|
Sorry for the late reply, will add this when I have some time :) |
|
Well that was easy :P |
niklasmohrin
approved these changes
Aug 7, 2021
dmaahs2017
reviewed
Aug 31, 2021
|
looks good to me @dbrgn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configuration option for displaying information with the italics style.
Fixes #146
Before:
After (configured example_variable to use italic instead of underline):
