Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test macos alias behavior #406

Closed
niklasmohrin opened this issue Jan 9, 2025 · 0 comments · Fixed by #407
Closed

Test macos alias behavior #406

niklasmohrin opened this issue Jan 9, 2025 · 0 comments · Fixed by #407
Labels
good-first-issue spec This issue involves the tldr client specification. testing

Comments

@niklasmohrin
Copy link
Collaborator

In #215, we added support for the "macos" platform which works as an alias for "osx". This was later included in version 2.0 of the client specification. However, we don't really have tests for this, as "osx" does not appear in our test suite at all and "macos" only appears once in another context.

Tests should be added that ensure that both "macos" and "osx" map to "osx" directory in the page cache. To do so, a test in tests/lib.rs should create a cache with a page for the "osx" platform and check that it is found in a normal tldr invocation and in tldr --list.

@niklasmohrin niklasmohrin added good-first-issue testing spec This issue involves the tldr client specification. labels Jan 9, 2025
beatbrot added a commit to beatbrot/tealdeer that referenced this issue Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue spec This issue involves the tldr client specification. testing
Development

Successfully merging a pull request may close this issue.

1 participant