Added file icons #40
Merged
Added file icons #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kdserra
commented
May 21, 2021
•
kdserra
commented
|
Thanks for the PR! :) I wish we could extend the user's icon theme with the custom icons, instead of exposing a separate "Teal Icons" theme. This PR implements this idea: microsoft/vscode#118846 With that said, I believe the current approach is fine for now. |
pdesaulniers
requested changes
May 21, 2021
This reverts commit 5ad1cbc.
|
FYI, it is now possible to associate default icons for a language in vscode. It is not necessary to create a separate icon theme anymore :) I have implemented this in b9729a3. I made the logo green to make it easier to differentiate from the Lua logo. It's not technically correct, but I think it looks nice :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.