Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings in teamcity-server.log #153

Closed
ogerovich opened this issue Mar 12, 2020 · 7 comments
Closed

Warnings in teamcity-server.log #153

ogerovich opened this issue Mar 12, 2020 · 7 comments

Comments

@ogerovich
Copy link

Expected Behavior

No WARN messages from the plugin.

Current Behavior

[2020-03-12 15:39:16,252]   INFO - rver.plugins.PluginsCollection - Load shared classloader for 0 plugins []
[2020-03-12 15:39:16,253]   INFO - rver.plugins.PluginsCollection - Load standalone classloaders for 1 plugins [tcWebHooks]
[2020-03-12 15:39:16,435]   INFO -   jetbrains.buildServer.SERVER - WebHookPayloadManager :: Starting
[2020-03-12 15:39:16,445]   INFO -   jetbrains.buildServer.SERVER - WebHookAuthenticatorProvider :: Starting
[2020-03-12 15:39:16,468]   INFO -   jetbrains.buildServer.SERVER - WebHookTemplateManager :: Starting (webhook.teamcity.payload.WebHookTemplateManager@69715756)
[2020-03-12 15:39:16,502]   INFO -   jetbrains.buildServer.SERVER - WebHookListener ::  :: Starting
[2020-03-12 15:39:16,507]   INFO -   jetbrains.buildServer.SERVER - WebHookListener ::  :: Registering
[2020-03-12 15:39:16,527]   WARN - .InstantiationStrategySelector - Spring selected non-public constructor to create instance: protected webhook.teamcity.extension.WebHookProjectTabExtension(jetbrains.buildServer.web.openapi.PagePlaces,jetbrains.buildServer.serverSide.ProjectManager,jetbrains.buildServer.serverSide.settings.ProjectSettingsManager,jetbrains.buildServer.web.openapi.PluginDescriptor,webhook.teamcity.history.WebHookHistoryRepository,webhook.teamcity.history.WebAddressTransformer)
[2020-03-12 15:39:16,534]   WARN - .InstantiationStrategySelector - Spring selected non-public constructor to create instance: protected webhook.teamcity.extension.WebHookBuildTypeTabExtension(jetbrains.buildServer.serverSide.ProjectManager,jetbrains.buildServer.serverSide.settings.ProjectSettingsManager,jetbrains.buildServer.web.openapi.WebControllerManager,jetbrains.buildServer.web.openapi.PluginDescriptor,webhook.teamcity.history.WebHookHistoryRepository,webhook.teamcity.history.WebAddressTransformer)
[2020-03-12 15:39:16,571]   INFO -   jetbrains.buildServer.SERVER - EndPointController:: Registering
[2020-03-12 15:39:16,577]   INFO -   jetbrains.buildServer.SERVER - EndPointController:: Registering

Steps to Reproduce (for bugs)

  1. Upload the plugin to the server that never had it and enable it or restart a server that had it
  2. Check teamcity-server.log.

Your Environment

  • tcWebHooks Version: 1.1.355.396
  • TeamCity Version: 2019.2.2
  • TeamCity server Operating System: Windows 10
  • Are you using a WebHook Template?: No
@netwolfuk
Copy link
Member

Hi @ogerovich. Thanks taking the time to report this.
Last time I saw this I thought that the problem is because I'm extending the TeamCity provided classes for this stuff, but I'll take another look.

Do you work with jetbrains? Is this a solvable problem, and I'm doing something wrong?

@netwolfuk
Copy link
Member

Oh. Looking at the code this should have a public constructor. I'll try to fix over the weekend.

@ogerovich
Copy link
Author

Hi @netwolfuk.
I'm a JetBrains customer and use TeamCity along with your plugin. Unfortunately, I'm not very familiar with plugins to recommend anything. I just noticed these warnings and wanted to let you know.

@netwolfuk
Copy link
Member

Thanks. That's cool.

I've fixed the issue, I just want to do some more testing and will do a release this weekend.

netwolfuk added a commit that referenced this issue Mar 13, 2020
@netwolfuk
Reduce logging noise from WebHook components Fixes #153
0a1f1fd 
Some TeamCity pages had protected constructors - now made public.
Lots of noisy logging messages reduced from INFO to DEBUG.

Hopefully, the logging level is not more useful and less verbose for
uses with the minimum level set to INFO (the default for a TeamCity
install).
@netwolfuk
Copy link
Member

netwolfuk commented Mar 16, 2020 •
edited
Loading

1.1.362.398 Released. Closing ticket.

@ogerovich
Copy link
Author

Thank you. I deployed the plugin. No more warnings.

@netwolfuk
Copy link
Member

Great. Thanks for the feedback

netwolfuk added a commit that referenced this issue Mar 17, 2020
@netwolfuk
Reduce logging noise from WebHook components Fixes #153
f412472 
Some TeamCity pages had protected constructors - now made public.
Lots of noisy logging messages reduced from INFO to DEBUG.

Hopefully, the logging level is now more useful and less verbose for
users with the minimum level set to INFO (the default for a TeamCity
install).

Conflicts:
	tcwebhooks-core/src/main/java/webhook/teamcity/WebHookListener.java
	tcwebhooks-core/src/main/java/webhook/teamcity/settings/WebHookMainSettings.java
	tcwebhooks-web-ui/src/main/java/webhook/teamcity/extension/WebHookBuildTypeTabExtension.java
	tcwebhooks-web-ui/src/main/java/webhook/teamcity/extension/WebHookProjectTabExtension.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@netwolfuk @ogerovich