Skip to content

Commit

Permalink
Remove plugin hot-reloading as it not compatible with TC2018 and below
Browse files Browse the repository at this point in the history
Versions of TeamCity up to and including 2018.1.5 failed to laod the
plugin correctly if the ` allow-runtime-reload="true"` option was
enabled in the `teamcity-plugin.xml` file.

The `teamcity-plugin.xml` is validated against an XML schema, so older
versions of TeamCity fail to validate and load the configuration.

Fixes issue #154
  • Loading branch information
netwolfuk committed Apr 6, 2020
1 parent 909fce5 commit 2e06a5c
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 48 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<groupId>netwolfuk.teamcity.plugins.tcwebhooks</groupId>
<artifactId>tcwebhooks</artifactId>
<properties>
<majorVersion>1.2.0-alpha.4</majorVersion>
<majorVersion>1.2.0-alpha.5</majorVersion>
<buildNumber>snapshot</buildNumber>
<gitHash>${GIT_HASH}</gitHash>
<gitBranch>${GIT_BRANCH}</gitBranch>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
<?xml version="1.0" encoding="UTF-8"?>
<teamcity-plugin xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:shemas-jetbrains-com:teamcity-plugin-v1-xml">
<info>
<name>tcWebHooks-rest-api</name>
<display-name>Web Hooks REST API (tcWebHooks)</display-name>
<version>${majorVersion}</version>
<description>REST API for configuring tcWebhooks plugin.
This plugin adds support for configuring the tcWebHook Templates feature, with plans to support configuring Webhooks in future.

- Branch: ${gitBranch}
- Revision: ${gitHash}
- Build: ${buildNumber}
</description>
<download-url>https://github.com/tcplugins/tcWebHooks/releases</download-url>
<vendor>
<name>Net Wolf</name>
<url>http://netwolfuk.wordpress.com/teamcity-plugins/</url>
</vendor>
</info>
<deployment use-separate-classloader="true" allow-runtime-reload="true"/>
<dependencies>
<plugin name="tcWebHooks"/>
<plugin name="rest-api"/>
</dependencies>
</teamcity-plugin>
<?xml version="1.0" encoding="UTF-8"?>
<teamcity-plugin xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:shemas-jetbrains-com:teamcity-plugin-v1-xml">
<info>
<name>tcWebHooks-rest-api</name>
<display-name>Web Hooks REST API (tcWebHooks)</display-name>
<version>${majorVersion}</version>
<description>REST API for configuring tcWebhooks plugin.
This plugin adds support for configuring the tcWebHook Templates feature, with plans to support configuring Webhooks in future.

- Branch: ${gitBranch}
- Revision: ${gitHash}
- Build: ${buildNumber}
</description>
<download-url>https://github.com/tcplugins/tcWebHooks/releases</download-url>
<vendor>
<name>Net Wolf</name>
<url>http://netwolfuk.wordpress.com/teamcity-plugins/</url>
</vendor>
</info>
<deployment use-separate-classloader="true"/>
<dependencies>
<plugin name="tcWebHooks"/>
<plugin name="rest-api"/>
</dependencies>
</teamcity-plugin>
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
<?xml version="1.0" encoding="UTF-8"?>
<teamcity-plugin xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:shemas-jetbrains-com:teamcity-plugin-v1-xml">
<info>
<name>tcWebHooks</name>
<display-name>Web Hooks (tcWebHooks)</display-name>
<version>${majorVersion}</version>
<description>Trigger webhook POST requests from build events.
This plugin adds new tabs to the Project and Build pages for viewing and configuring WebHook events.

- Branch: ${gitBranch}
- Revision: ${gitHash}
- Build: ${buildNumber}
</description>
<download-url>https://github.com/tcplugins/tcWebHooks/releases</download-url>
<vendor>
<name>Net Wolf</name>
<url>http://netwolfuk.wordpress.com/teamcity-plugins/</url>
</vendor>
</info>
<deployment use-separate-classloader="true" allow-runtime-reload="true"/>
<?xml version="1.0" encoding="UTF-8"?>
<teamcity-plugin xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:shemas-jetbrains-com:teamcity-plugin-v1-xml">
<info>
<name>tcWebHooks</name>
<display-name>Web Hooks (tcWebHooks)</display-name>
<version>${majorVersion}</version>
<description>Trigger webhook POST requests from build events.
This plugin adds new tabs to the Project and Build pages for viewing and configuring WebHook events.

- Branch: ${gitBranch}
- Revision: ${gitHash}
- Build: ${buildNumber}
</description>
<download-url>https://github.com/tcplugins/tcWebHooks/releases</download-url>
<vendor>
<name>Net Wolf</name>
<url>http://netwolfuk.wordpress.com/teamcity-plugins/</url>
</vendor>
</info>
<deployment use-separate-classloader="true" />
</teamcity-plugin>

0 comments on commit 2e06a5c

Please sign in to comment.