Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/#348/semicolons #760

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix/#348/semicolons #760

merged 1 commit into from
Feb 11, 2025

Conversation

tconbeer
Copy link
Owner

@tconbeer tconbeer commented Feb 11, 2025

Closes #348

What are the key elements of this solution?
Uses tree-sitter and tree-sitter-sql to query the document for semicolon tokens, instead of naively searching the document for semicolon strings.

Why did you design your solution this way? Did you assess any alternatives? Are there tradeoffs?
The new tree-sitter-sql is quite good, and actively maintained. This method seemed resilient even in cases where there were parsing errors thrown by tree-sitter-sql

Does this PR require a change to Harlequin's docs?

  • No.
  • Yes, and I have opened a PR at tconbeer/harlequin-web.
  • Yes; I haven't opened a PR, but the gist of the change is: add troubleshooting page for installing tree sitter.

Did you add or update tests for this change?

  • Yes.
  • No, I believe tests aren't necessary.
  • No, I need help with testing this change.

Please complete the following checklist:

  • I have added an entry to CHANGELOG.md, under the [Unreleased] section heading. That entry references the issue closed by this PR.
  • I acknowledge Harlequin's MIT license. I do not own my contribution.

@tconbeer tconbeer force-pushed the fix/#348/semicolons branch from f10f070 to dba2004 Compare February 11, 2025 16:28
@tconbeer tconbeer merged commit 165b0ca into main Feb 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queries cannot contain a string literal or quoted name with a semicolon (e.g., ';')
1 participant