Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate translations to module #774

Merged
merged 10 commits into from
Oct 27, 2023
Merged

Conversation

estellecomment
Copy link
Contributor

@estellecomment estellecomment commented Oct 11, 2023

Add a module containing translations.

  • tchap_translations.json is still the same, it just moved.
  • the module is a yarn/npm module, but placed in out own files, not in another repo or package server. If we put it in a separate repo, we would need to make sure the version of the translations module matched the code in the patches+customisations, so that for any change you would need two separate PRs. We used to do this with matrix-react-sdk and it was awful.
  • Changes in module code are not picked up by webpack-dev-server, not sure how to do that. So you need to stop and restart the server to see any changes, which is quite long. 🤷‍♀️

Edit : modified the installer to no run yarn add, because this broke scalingo. See #776

Cypress still broken in CI, but runs locally (only on prod env though. Not sure why.)

@estellecomment
Copy link
Contributor Author

Ah zut la review app est pétée. Bon.

@estellecomment
Copy link
Contributor Author

The problem is coming from the yarn add that is run to install modules. I suspect scalingo wants yarn add to be run during install phase, and not after.

image

@estellecomment estellecomment marked this pull request as draft October 12, 2023 08:07
@estellecomment estellecomment marked this pull request as ready for review October 24, 2023 15:35
@estellecomment
Copy link
Contributor Author

Merging without review because it's been there long enough !

@estellecomment estellecomment merged commit ed1f5e3 into develop_tchap Oct 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant