-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal ui changes and config #7
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ set -x | |
|
||
tmpdir=`mktemp -d 2>/dev/null || mktemp -d -t 'icontmp'` | ||
|
||
for i in 1024 512 310 256 192 180 152 150 144 128 120 114 96 76 72 70 64 60 57 48 36 32 24 16 | ||
for i in 1024 512 310 300 256 192 180 152 150 144 128 120 114 96 88 76 72 70 64 60 57 50 48 44 36 32 24 16 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Est-ce que ca vaudrait pas le coup de faire une copie du script, make-tchap-icons.sh, vu qu'il y a plein de changements ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ce script est pas mis à jour depuis perpet, ils l'utilisent certainement plus à mon avis.Je peux aussi ne pas le commit du tout, c'est juste un helper à utiliser une fois There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ca serait bien de documenter les modifications, vite fait : ya des parties enlevées et rajoutées qui sont un peu mysterieuses pour moi. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. C'est juste les tailles des icones générées. Il y a des tailles qui manquent par rapport aux icones présentes dans la version actuelle d'element et j'avais pas envie de les faire à la main. En gros le script génère plein de taille d'images, et selectionne ensuite les bonnes pour les renommer. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. J'ai viré des parties qui buguent, parce qu'on à pas de build electron |
||
do | ||
#convert -background none -density 1000 -resize $i -extent $i -gravity center "$1" "$tmpdir/$i.png" | ||
|
||
|
@@ -59,22 +59,34 @@ cp "$tmpdir/512.png" "$tmpdir/Riot.iconset/[email protected]" | |
cp "$tmpdir/512.png" "$tmpdir/Riot.iconset/icon_512x512.png" | ||
cp "$tmpdir/1024.png" "$tmpdir/Riot.iconset/[email protected]" | ||
|
||
if [ -x "$(command -v iconutil)" ]; then | ||
# available on macos | ||
iconutil -c icns -o electron_app/build/icon.icns "$tmpdir/Riot.iconset" | ||
elif [ -x "$(command -v png2icns)" ]; then | ||
# available on linux | ||
# png2icns is more finicky about its input than iconutil | ||
# 1. it doesn't support a 64x64 (aka 32x32@2x) | ||
# 2. it doesn't like duplicates (128x128@2x == 256x256) | ||
rm "$tmpdir/Riot.iconset/[email protected]" | ||
rm "$tmpdir/Riot.iconset/[email protected]" | ||
rm "$tmpdir/Riot.iconset/[email protected]" | ||
rm "$tmpdir/Riot.iconset/[email protected]" | ||
png2icns electron_app/build/icon.icns "$tmpdir"/Riot.iconset/*png | ||
else | ||
echo "WARNING: Unsupported platform. Skipping icns build" | ||
fi | ||
#if [ -x "$(command -v iconutil)" ]; then | ||
# # available on macos | ||
# iconutil -c icns -o electron_app/build/icon.icns "$tmpdir/Riot.iconset" | ||
#elif [ -x "$(command -v png2icns)" ]; then | ||
# # available on linux | ||
# # png2icns is more finicky about its input than iconutil | ||
# # 1. it doesn't support a 64x64 (aka 32x32@2x) | ||
# # 2. it doesn't like duplicates (128x128@2x == 256x256) | ||
# rm "$tmpdir/Riot.iconset/[email protected]" | ||
# rm "$tmpdir/Riot.iconset/[email protected]" | ||
# rm "$tmpdir/Riot.iconset/[email protected]" | ||
# rm "$tmpdir/Riot.iconset/[email protected]" | ||
# png2icns electron_app/build/icon.icns "$tmpdir"/Riot.iconset/*png | ||
#else | ||
# echo "WARNING: Unsupported platform. Skipping icns build" | ||
#fi | ||
|
||
cp "$tmpdir/24.png" "res/vector-icons/24.png" | ||
cp "$tmpdir/44.png" "res/vector-icons/44.png" | ||
cp "$tmpdir/50.png" "res/vector-icons/50.png" | ||
cp "$tmpdir/76.png" "res/vector-icons/76.png" | ||
cp "$tmpdir/88.png" "res/vector-icons/88.png" | ||
cp "$tmpdir/120.png" "res/vector-icons/120.png" | ||
cp "$tmpdir/150.png" "res/vector-icons/150.png" | ||
cp "$tmpdir/152.png" "res/vector-icons/152.png" | ||
cp "$tmpdir/180.png" "res/vector-icons/180.png" | ||
cp "$tmpdir/300.png" "res/vector-icons/300.png" | ||
cp "$tmpdir/1024.png" "res/vector-icons/1024.png" | ||
|
||
cp "$tmpdir/36.png" "res/vector-icons/android-chrome-36x36.png" | ||
cp "$tmpdir/48.png" "res/vector-icons/android-chrome-48x48.png" | ||
|
@@ -84,34 +96,34 @@ cp "$tmpdir/144.png" "res/vector-icons/android-chrome-144x144.png" | |
cp "$tmpdir/192.png" "res/vector-icons/android-chrome-192x192.png" | ||
cp "$tmpdir/180.png" "res/vector-icons/apple-touch-icon.png" | ||
cp "$tmpdir/180.png" "res/vector-icons/apple-touch-icon-precomposed.png" | ||
cp "$tmpdir/57.png" "res/vector-icons/apple-touch-icon-57x57.png" | ||
cp "$tmpdir/60.png" "res/vector-icons/apple-touch-icon-60x60.png" | ||
cp "$tmpdir/72.png" "res/vector-icons/apple-touch-icon-72x72.png" | ||
cp "$tmpdir/76.png" "res/vector-icons/apple-touch-icon-76x76.png" | ||
cp "$tmpdir/114.png" "res/vector-icons/apple-touch-icon-114x114.png" | ||
cp "$tmpdir/120.png" "res/vector-icons/apple-touch-icon-120x120.png" | ||
cp "$tmpdir/144.png" "res/vector-icons/apple-touch-icon-144x144.png" | ||
cp "$tmpdir/152.png" "res/vector-icons/apple-touch-icon-152x152.png" | ||
cp "$tmpdir/180.png" "res/vector-icons/apple-touch-icon-180x180.png" | ||
cp "$tmpdir/57.png" "res/vector-icons/apple-touch-icon-57.png" | ||
cp "$tmpdir/60.png" "res/vector-icons/apple-touch-icon-60.png" | ||
cp "$tmpdir/72.png" "res/vector-icons/apple-touch-icon-72.png" | ||
cp "$tmpdir/76.png" "res/vector-icons/apple-touch-icon-76.png" | ||
cp "$tmpdir/114.png" "res/vector-icons/apple-touch-icon-114.png" | ||
cp "$tmpdir/120.png" "res/vector-icons/apple-touch-icon-120.png" | ||
cp "$tmpdir/144.png" "res/vector-icons/apple-touch-icon-144.png" | ||
cp "$tmpdir/152.png" "res/vector-icons/apple-touch-icon-152.png" | ||
cp "$tmpdir/180.png" "res/vector-icons/apple-touch-icon-180.png" | ||
cp "$tmpdir/16.png" "res/vector-icons/favicon-16x16.png" | ||
cp "$tmpdir/32.png" "res/vector-icons/favicon-32x32.png" | ||
cp "$tmpdir/96.png" "res/vector-icons/favicon-96x96.png" | ||
cp "$tmpdir/70.png" "res/vector-icons/mstile-70x70.png" | ||
cp "$tmpdir/144.png" "res/vector-icons/mstile-144x144.png" | ||
cp "$tmpdir/150.png" "res/vector-icons/mstile-150x150.png" | ||
cp "$tmpdir/310.png" "res/vector-icons/mstile-310x310.png" | ||
cp "$tmpdir/70.png" "res/vector-icons/mstile-70.png" | ||
cp "$tmpdir/144.png" "res/vector-icons/mstile-144.png" | ||
cp "$tmpdir/150.png" "res/vector-icons/mstile-150.png" | ||
cp "$tmpdir/310.png" "res/vector-icons/mstile-310.png" | ||
cp "$tmpdir/310x150.png" "res/vector-icons/mstile-310x150.png" | ||
cp "$tmpdir/180.png" "electron_app/img/riot.png" | ||
#cp "$tmpdir/180.png" "electron_app/img/riot.png" | ||
|
||
convert "$tmpdir/16.png" "$tmpdir/32.png" "$tmpdir/64.png" "$tmpdir/128.png" "$tmpdir/256.png" "res/vector-icons/favicon.ico" | ||
|
||
cp "res/vector-icons/favicon.ico" "electron_app/build/icon.ico" | ||
cp "res/vector-icons/favicon.ico" "electron_app/img/riot.ico" | ||
#cp "res/vector-icons/favicon.ico" "electron_app/build/icon.ico" | ||
#cp "res/vector-icons/favicon.ico" "electron_app/img/riot.ico" | ||
|
||
# https://github.com/electron-userland/electron-builder/blob/3f97b86993d4ea5172e562b182230a194de0f621/src/targets/LinuxTargetHelper.ts#L127 | ||
for i in 24 96 16 48 64 128 256 512 | ||
do | ||
cp "$tmpdir/$i.png" "electron_app/build/icons/${i}x${i}.png" | ||
done | ||
#for i in 24 96 16 48 64 128 256 512 | ||
#do | ||
# cp "$tmpdir/$i.png" "electron_app/build/icons/${i}x${i}.png" | ||
#done | ||
|
||
rm -r "$tmpdir" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on peut l'appeler juste Tchap ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, contrainte technique pour éviter les conflits de noms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mais ça apparait comme "Tchap" dans la sélection