Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message when domain is not allowed on Tchap #512

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Add error message when domain is not allowed on Tchap #512

merged 3 commits into from
Mar 31, 2023

Conversation

odelcroi
Copy link
Member

Before :
see ticket #460

After :
Capture d’écran 2023-03-30 à 15 43 25

@odelcroi odelcroi linked an issue Mar 30, 2023 that may be closed by this pull request
user register: improve error message when domain is not register #460
Closed
3 tasks
@odelcroi odelcroi requested review from aulamber and chaibax March 30, 2023 13:47
@odelcroi
Copy link
Member Author

odelcroi commented Mar 30, 2023 •
edited
Loading

  • What about external users that don't have an invit? test if they have the same message
  • Yes, they do, maybe the message should talk to external users too
  • maybe the link should go to https://tchap.beta.gouv.fr/

@odelcroi odelcroi requested a review from areox-net March 30, 2023 14:53
areox-net
areox-net requested changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@areox-net areox-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message is ok.
However, I would not use the blue color for the link. It could just be an underlined part of the red text.

@odelcroi odelcroi mentioned this pull request Mar 31, 2023
Closed
1 task
odelcroi added 2 commits March 31, 2023 11:21
@odelcroi
change link style
cc4a4d1
@odelcroi
Merge branch 'develop_tchap' of https://github.com/tchapgouv/tchap-we…
34d1e57 
…b-v4 into 460-user-register-improve-error-message-when-domain-is-not-register
@odelcroi odelcroi closed this Mar 31, 2023
@odelcroi odelcroi reopened this Mar 31, 2023
@odelcroi odelcroi merged commit c4244cd into develop_tchap Mar 31, 2023
@odelcroi odelcroi deleted the 460-user-register-improve-error-message-when-domain-is-not-register branch March 31, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@areox-net areox-net areox-net approved these changes

@aulamber aulamber Awaiting requested review from aulamber

@chaibax chaibax Awaiting requested review from chaibax

Assignees
No one assigned
Labels
proposal to element
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user register: improve error message when domain is not register
2 participants
@odelcroi @areox-net