Allow intradef users to invite users from other homeserver in a private room #446
Conversation
…e room by default
src/util/TchapUtils.ts
Outdated
| @@ -35,7 +35,7 @@ export default class TchapUtils { | |||
| // Only show the federate switch to defense users : it's difficult to understand, so we avoid | |||
| // displaying it unless it's really necessary. | |||
| if (baseDomain === 'agent.intradef.tchap.gouv.fr') { | |||
| return { showRoomFederationOption: true, roomFederationDefault: false }; | |||
| return { showRoomFederationOption: true, roomFederationDefault: true }; | |||
There was a problem hiding this comment.
@aulamber In case of "forum" default is false, in case private room (external or not, it's always federation default)
There was a problem hiding this comment.
Maybe you can change the isFederation : this.setState({ tchapRoomType: tchapRoomType }); if the room type isn't public room, isFederated is set to true.
It will be better to enforce the federation parameter at moment of the room is creation (I haven't found were is the code of that).
|
Close #370 |
| private onCancel = () => { | ||
| this.props.onFinished(false); | ||
| }; | ||
|
|
||
| private onFederatedChange = (isFederated: boolean) => { | ||
| this.setState({ isFederated: isFederated }); | ||
| private onFederatedChange = (isForumFederated: boolean) => { |
| const cli = MatrixClientPeg.get(); | ||
| const baseDomain = cli.getDomain(); | ||
|
|
||
| // Only show the federate switch to defense users : it's difficult to understand, so we avoid | ||
| // displaying it unless it's really necessary. | ||
| if (baseDomain === 'agent.intradef.tchap.gouv.fr') { | ||
| return { showRoomFederationOption: true, roomFederationDefault: false }; |
There was a problem hiding this comment.
it should be : {showForumFederationSwitch: true, forumFederationSwitchDefaultValue: false}
|
Je lance une review app pour tester |
|
@aulamber il manque quoi pour merger ? |
En fait non, parce que ca peut etre n'importe quelle room qui peut etre federee, pas seulement le forum :) |
Cf. issue #370
To reproduce the bugfix:
Cf. before there was a popin saying: