add a feature flag in config.json for xsss and unify previous patches #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
odelcroi
changed the title
jdauphant
approved these changes
Mar 2, 2023
aulamber
approved these changes
Mar 3, 2023
odelcroi
deleted the
433-flag-to-activatedeactivate-cross-signing-set-in-configjson
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
feature flag was hard-coded in code
After
the feature flag is in the config.json / features / "tchap_activate_cross_signing" : [true/false]
NOTE : 4 previous patches around xsss have been merged in 2 new patches (one for matrix-react-sdk and one for matrix-js-sdk)
This PR does not include this issue : #445
When feature flag is FALSE
When flag is TRUE