Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(faq): add faq button in space panel #1063

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

MarcWadai
Copy link
Contributor

@MarcWadai MarcWadai commented Jul 11, 2024

fixes #395

Before

image

After

image

@MarcWadai MarcWadai requested a review from areox-net July 11, 2024 16:05
@areox-net
Copy link
Contributor

areox-net commented Jul 11, 2024

@MarcWadai Pas mal.

Quelques adjustements sur couleurs et icones:

  • Avec du recul pense qu'il vaut mieux rester sur des icones blanches pour la sidebar, y compris pour la Gauffre (voir échanges sur salons de La Suite)
  • Dans le menu, j'inverserais les icones "Foire aux Questions" et "Prise en main". Les utilisaters qui associent déjà l'icone actuelle à la FAQ ne vont pas etre perdus.

Au passage c'est bien d'avoir fait une passe de cohérence, car l'"Aide" sur mobile s'appelle "Foires aux questions"
@Delphgateau, @Nivann, @Raphaelrobert65 quel terme trouvez-vous le plus adapté ?

@MarcWadai MarcWadai force-pushed the 395-improve-faq-visibility branch from ced114e to 2e9b098 Compare July 15, 2024 10:38
Copy link
Contributor

@areox-net areox-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nickel !

@Delphgateau
Copy link

Je trouve que Foire aux questions est plus clair

@MarcWadai MarcWadai merged commit 1e66aa1 into develop_tchap Jul 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Améliorer la visibilité de la FAQ
3 participants