Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activer les appels AUDIO sur web pour les users DINUM #844

Closed
3 of 6 tasks
Tracked by #241
odelcroi opened this issue Nov 29, 2023 · 3 comments · Fixed by #856 or #857
Closed
3 of 6 tasks
Tracked by #241

activer les appels AUDIO sur web pour les users DINUM #844

odelcroi opened this issue Nov 29, 2023 · 3 comments · Fixed by #856 or #857
Labels
P1 Priority 1 web

Comments

@odelcroi
Copy link
Member

odelcroi commented Nov 29, 2023

  • Uniquement pour les DM
  • Uniquement les appels Audio
  • Tests liés aux appels

RoomHeader has been reworked in Element

RoomHeader.tsx and LegacyRoomHeader.tsx
the new RoomHeader can be activated with the option :

    "features": {
        "feature_new_room_decoration_ui" : true
..

Activating only the audio button only for DM for Dinum

1/
A patch can be made to filter the render of the button is room is a DM and the user is part of the homeserver dinum

What is the UX difference between both :

LegacyRoomHeader

image

RoomHeader

  • DM
image
  • Room
image

Throughts

  • The new version is lighter
  • It is way easy to customize RoomHeader.tsx than LegacyRoomHeader
  • LegacyRoomHeader is flagged as deprecated in the code

it seems to be a good idea to activate the new RoomHeader.tsx

Questions

  • what is the status of the new version in terms of development?
  • is there dramatic UX impacts if we activate it?
  • activate new room header in tchap labs
@odelcroi odelcroi transferred this issue from tchapgouv/tchap-product Nov 29, 2023
@github-actions github-actions bot added the web label Nov 29, 2023
@estellecomment estellecomment added the P1 Priority 1 label Dec 12, 2023
@estellecomment
Copy link
Contributor

Would be nice to do the modifications (buttons to hide, etc) as a module if possible.
Modules should allow us to have no regressions (or less regressions :)) in the future, since element will know about the module's hooks in element-web, and won't break them.

@odelcroi odelcroi linked a pull request Dec 13, 2023 that will close this issue
@odelcroi
Copy link
Member Author

added desc on RoomHeader and LegacyRoomHeader

@odelcroi odelcroi linked a pull request Dec 13, 2023 that will close this issue
3 tasks
@odelcroi odelcroi reopened this Dec 14, 2023
@odelcroi
Copy link
Member Author

regresionns :

  • external room header is not displayed
  • forum icon is displayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority 1 web
Projects
None yet
2 participants