Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate audio and video call based on featureflag #856

Conversation

odelcroi
Copy link
Member

@odelcroi odelcroi commented Dec 13, 2023

See config files :
https://github.com/tchapgouv/tchap-web-v4/blob/e1b718e098fde7ea48a76384c7ab7984686f1a44/config.dev.json

With External users before :

Capture d’écran 2023-12-14 à 14 48 12

With External users after :

Capture d’écran 2023-12-14 à 14 47 52

With Audio call before :

Capture d’écran 2023-12-14 à 14 48 28

With Audio call after :

Capture d’écran 2023-12-14 à 14 48 43

Checklist

@odelcroi odelcroi linked an issue Dec 13, 2023 that may be closed by this pull request
6 tasks
@odelcroi odelcroi changed the title Activate voip on all env Activate audio and video call based on featureflag Dec 13, 2023
@odelcroi
Copy link
Member Author

@areox-net the caption "ouvert aux externes" was easier to set before the name of the room, do you see a problem?

@areox-net
Copy link
Contributor

@odelcroi It's not the best solution, but I understand it's better for rooms with long titles.
Ideally, I'd put it under the room name in a Title+Subtitle logic.

@NicolasBuquet
Copy link

@odelcroi : Shouldn't we leave video call out of scope in this PR?

@odelcroi
Copy link
Member Author

@odelcroi It's not the best solution, but I understand it's better for rooms with long titles. Ideally, I'd put it under the room name in a Title+Subtitle logic.

In this new version, under the room title, there is the room descritpion

@odelcroi
Copy link
Member Author

@odelcroi : Shouldn't we leave video call out of scope in this PR?

The video button is hidden with a feature flag, then we can display it progressively with no code modification

@odelcroi odelcroi marked this pull request as draft January 8, 2024 15:21
@odelcroi odelcroi marked this pull request as ready for review January 10, 2024 10:29
@odelcroi odelcroi merged commit ae0fcb1 into develop_tchap Jan 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

activer les appels AUDIO sur web pour les users DINUM
3 participants