Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lien invalide pour certaines faq #141

Merged
merged 1 commit into from
Dec 19, 2022
Merged

fix: lien invalide pour certaines faq #141

merged 1 commit into from
Dec 19, 2022

Conversation

odelcroi
Copy link
Member

@odelcroi odelcroi commented Dec 14, 2022 •
edited
Loading

Fixed:

  • Le lien généré pour certains paragraphes était invalide
  • Le lien généré lorsqu'un #anchor était déjà présent dans l'url était systématiquement invalide

@odelcroi odelcroi linked an issue Dec 14, 2022 that may be closed by this pull request
bug : je veux partager un lien de faq #140
Closed
@odelcroi odelcroi requested review from Nivann and jdauphant December 14, 2022 13:54
@odelcroi
Copy link
Member Author

an issue is created because anchor system is tedious and prone to errors : #142

odelcroi
odelcroi commented Dec 14, 2022
View reviewed changes
src/pages/faq/FaqComponent.js
"tcq07_005": false,
"tcq08_001": false,
"tcq08_002": false,
"tcq08_003": false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure it is needed

@odelcroi odelcroi linked an issue Dec 14, 2022 that may be closed by this pull request
Cliquer sur un "+" déplie 2 sections en même temps #134
Closed
@odelcroi odelcroi merged commit 39e7425 into prod Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nivann Nivann Awaiting requested review from Nivann

@jdauphant jdauphant Awaiting requested review from jdauphant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug : je veux partager un lien de faq Cliquer sur un "+" déplie 2 sections en même temps
1 participant
@odelcroi