Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

731 bad parameter in xcodegen parameter file targetyml #733

Merged
merged 2 commits into from
Feb 2, 2023
Merged

731 bad parameter in xcodegen parameter file targetyml #733

merged 2 commits into from
Feb 2, 2023

Conversation

NicolasBuquet
Copy link
Contributor

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@NicolasBuquet NicolasBuquet requested a review from giomfo February 1, 2023 17:54
@NicolasBuquet NicolasBuquet self-assigned this Feb 1, 2023
@NicolasBuquet NicolasBuquet linked an issue Feb 1, 2023 that may be closed by this pull request
Bad parameter in xcodegen parameter file target.yml #731
Closed
giomfo
giomfo approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@NicolasBuquet NicolasBuquet merged commit 690be59 into develop Feb 2, 2023
@NicolasBuquet NicolasBuquet deleted the 731-bad-parameter-in-xcodegen-parameter-file-targetyml branch February 2, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giomfo giomfo giomfo approved these changes

Assignees

@NicolasBuquet NicolasBuquet

Labels
iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad parameter in xcodegen parameter file target.yml
2 participants
@NicolasBuquet @giomfo