Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CROSS_SIGNING and SECURE_BACKUP flags for DevTchap config #716

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Enable CROSS_SIGNING and SECURE_BACKUP flags for DevTchap config #716

merged 1 commit into from
Jan 25, 2023

Conversation

phloux
Copy link

@phloux phloux commented Jan 24, 2023

@phloux phloux marked this pull request as ready for review January 24, 2023 16:32
@phloux phloux requested a review from NicolasBuquet January 24, 2023 16:36
@NicolasBuquet
Copy link
Contributor

I think that you must not have space between -D and in OTHER_SWIFT_FLAGS values.

@giomfo
Copy link
Contributor

giomfo commented Jan 24, 2023

I think that you must not have space between -D and in OTHER_SWIFT_FLAGS values.

I don't think this is a pb

@NicolasBuquet
Copy link
Contributor

I saw cases where the symbol was not accessible to source code when the label wasn't stuck to -D flag. But maybe that was with old versions of Xcode. So I valid this PR.

@phloux phloux merged commit 1d1e55a into develop Jan 25, 2023
@phloux phloux deleted the phlpro/715-devtchap-flags branch January 25, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasBuquet NicolasBuquet NicolasBuquet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phloux @NicolasBuquet @giomfo