Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project cleaning] Remove unused Tchap source files #636

Closed
giomfo opened this issue Jul 28, 2022 · 2 comments
Closed

[Project cleaning] Remove unused Tchap source files #636

giomfo opened this issue Jul 28, 2022 · 2 comments
Assignees
Labels

Comments

@giomfo
Copy link
Contributor

giomfo commented Jul 28, 2022

We moved back several modules on the Element source code during the previous months
I request here to remove definitely unused Tchap source code (from Tchap sub folder)
Please create an issue for each module (feature) which was not moved back to Element yet in order to take a decision on them

@giomfo giomfo added the iOS label Jul 28, 2022
@giomfo giomfo changed the title [Project cleaning] Remove unused source files [Project cleaning] Remove unused Tchap source files Jul 28, 2022
@phloux phloux self-assigned this Aug 5, 2022
@phloux
Copy link

phloux commented Aug 9, 2022

After these changes, there is still Tchap specific code for those parts :

  • Authentication / Account creation
  • Change Password / Forgot Password
  • Account Validity
  • Password Policy
  • App version checker
  • Favorites Messages -> to be removed by a specific PR (Tchap will wait for Element implementation on favorite messages if any)
  • Global Search -> should be removed with Home manager? -> Removed
  • Avatar -> should be removed by adjusting some codes (like room access by link view model) -> Removed
  • Home -> should be removed now? -> Removed
  • Forward -> should be removed -> Removed
  • Public Rooms
  • Room Creation
  • Room Preview -> @phlniji can you please check whether we can remove it? -> Not removable: Used by Public Rooms
  • 3PID -> @phlniji can you please check whether we can remove it? -> Not removable: Used by UserService
  • Media Service -> @phlniji can you please check whether we can remove it? -> Not removable: Used by Room Creation
  • Invite by email
  • Identity Service
  • Home Server
  • Display Name

@giomfo
Copy link
Contributor Author

giomfo commented Aug 29, 2022

We will track the pending list with #663

@giomfo giomfo closed this as completed Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants