Fix the FCM token error #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claire1817
reviewed
Feb 15, 2022
vector/src/gplay/java/im/vector/app/push/fcm/NotificationTroubleshootTestManagerFactory.kt
Show resolved
Hide resolved
Co-authored-by: ClaireG <[email protected]>
giomfo
approved these changes
Feb 15, 2022
|
|
||
| <!-- Allow system certificates for firebase --> | ||
| <domain-config cleartextTrafficPermitted="false"> | ||
| <domain includeSubdomains="false">firebaseinstallations.googleapis.com</domain> |
There was a problem hiding this comment.
Should we consider the store dimension gplay vs fdroid before adding this domain config?
We may ignore this remark because fdroid variant is built without pinning, but I prefer mention it
There was a problem hiding this comment.
it's possible to have a specific network security config for gplay + withpinning variant
There was a problem hiding this comment.
Good catch, I just updated the PR and split the config file for both variants
Florian14
force-pushed
the
feature/fre/fix_fis_auth_error
branch
from
d26e79b to
c120368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#402
The FCM token could not be retrieved because of the pinning restriction which does not allow the system certificates. These certificates are required to request the FCM token through the firebase API. This PR allows the use of the system certificates for the firebase domain only.
This PR also hide the "Test push" step from the "Troubleshoot Notifications" screen. This step was triggering a notification using the push server
notifyendpoint. The push server has been moved to a new internal sygnal server which is only accessible from the Synapse. This step will be hidden while there is no equivalent public API to trigger a notification.