Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fixed terminal path #115

Closed
wants to merge 4 commits into from
Closed

[FIX] Fixed terminal path #115

wants to merge 4 commits into from

Conversation

VinayChaurasiyaA
Copy link
Member

@VinayChaurasiyaA VinayChaurasiyaA commented Oct 10, 2023 •
edited
Loading

Title : There is wrong path shown in terminal

Issue no : #114

Description

  • There is a issue, where the path is shown as ../.documents, which should be shown as the ../documents in the terminal.

Checklist

  • [X ] I have read and agree to abide by the Code of Conduct
  • [X ] I have read and followed the Contributing Guidelines

@harshau007 harshau007 changed the title #114 terminal path [FIX] Fixed terminal path Oct 10, 2023
@harshau007 harshau007 requested a review from beans9926 October 10, 2023 16:07
beans9926
beans9926 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@beans9926 beans9926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall minor changes, approved

Rishabh672003
Rishabh672003 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@Rishabh672003 Rishabh672003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but mention in PR that you have also pulled changes from main branch in readme

@Akash6222
Copy link
Member

This pr branch is based on main, issue branch should be based on xfce-de , therfore im closing this pr

@Akash6222 Akash6222 closed this Oct 11, 2023
@Akash6222 Akash6222 deleted the 114-terminal-path branch December 5, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beans9926 beans9926 beans9926 approved these changes

@Rishabh672003 Rishabh672003 Rishabh672003 approved these changes

@Akash6222 Akash6222 Awaiting requested review from Akash6222

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VinayChaurasiyaA @Akash6222 @Rishabh672003 @beans9926 @demonkillerr