Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#27 color-scheme-check #79

Merged
merged 4 commits into from
Dec 2, 2023
Merged

#27 color-scheme-check #79

merged 4 commits into from
Dec 2, 2023

Conversation

AtharvaTanpure18
Copy link
Member

@AtharvaTanpure18 AtharvaTanpure18 commented Nov 16, 2023

Title :

Color Scheme check for resume

Issue no : 27-color-scheme -heck #58

Description

A new file is added with relevant functionality.

Checklist

  • I have read and agree to abide by the Code of Conduct
  • I have read and followed the Contributing Guidelines

@AtharvaTanpure18 AtharvaTanpure18 marked this pull request as ready for review November 16, 2023 15:49
@sanyamjain0315 sanyamjain0315 changed the base branch from main to staging December 2, 2023 06:18
…ns.py'. Adding description for each function. Removed logging part added in previous commits because it does not serve much purpose yet.
Copy link
Contributor

@sanyamjain0315 sanyamjain0315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Suggestions

  • You could write more detailed PRs about functionalities you have implemented and how your code works
  • Write description for functions, describing their use, arguments they need and what they return. You can refer the description to your own functions added in 'ats_functions.py"

Looking forward to more contributions :)

@sanyamjain0315 sanyamjain0315 merged commit 034b076 into staging Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants