-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXED] restructured the directories and URL trails #22
Conversation
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some conflicts need to be addressed due to a recent merge to main. Nothing too complicated other than prettifying the code.
It needs to be done before our workflow accepts your PR's changes.
[solved] merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the routes for events (page) and core (page) are fixed, there are some more routes within the events page which won't work.
Two ways to solve them would be:
- Creating a directory for every event and adding an
index.html
in all of them (this is practiced by Documentation Team for making blogs.
OR - Revert the routes in
events/index.html
to it's previous state, other than the navbar.
However this only partially solves the issue and I recommend going for the first solution.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Adjusted the directory structure to ensure proper organization of files.
Updated links and references across the codebase to reflect the new URL structure.