Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] restructured the directories and URL trails #22

Merged
merged 5 commits into from
Aug 12, 2023

Conversation

rahulsingh2312
Copy link
Member

@rahulsingh2312 rahulsingh2312 commented Aug 11, 2023

Description

Adjusted the directory structure to ensure proper organization of files.
Updated links and references across the codebase to reflect the new URL structure.

Fixes

fixes #18

Checklist

  • Trailing urls will now not show .html on any page of the website
  • edited all the src and href for the new structure of directory
  • created a folder for events and a for core
  • created a folder for all events and moved all the images of them in thier respective folders

testing

I have thoroughly tested these changes by creating a dummy repo and github pages

screenshots

image
image

@prathikshetty2002
Copy link
Member

LGTM!

Copy link
Contributor

@vish-rt vish-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some conflicts need to be addressed due to a recent merge to main. Nothing too complicated other than prettifying the code.
It needs to be done before our workflow accepts your PR's changes.

@rahulsingh2312
Copy link
Member Author

[solved] merge conflicts

Copy link
Contributor

@vish-rt vish-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the routes for events (page) and core (page) are fixed, there are some more routes within the events page which won't work.
image

Two ways to solve them would be:

  • Creating a directory for every event and adding an index.html in all of them (this is practiced by Documentation Team for making blogs.
    OR
  • Revert the routes in events/index.html to it's previous state, other than the navbar.
    However this only partially solves the issue and I recommend going for the first solution.

@rahulsingh2312
Copy link
Member Author

  • created a folder for all events and moved all the images of them in thier respective folders

Copy link
Contributor

@vish-rt vish-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vish-rt vish-rt merged commit c8305c4 into tcet-opensource:main Aug 12, 2023
@demonkillerr demonkillerr changed the title [FIXED]restructured the directories and URL trails [FIXED] restructured the directories and URL trails Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure directories
3 participants