fail to create on databases that aren't UTF8
#281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PL/Rust can't support databases that aren't UTF8 because of Rust's requirements around Strings being proper UTF8. This PR causes
CREATE EXTENSION plrust
to raise an ERROR in this case:This might be a little heavy-handed now but it gives us time to consider other options for relaxing this requirement.
The decision here stems from the fact that, currently,
pgx
blindly assumes allTEXT
Datum conversions are valid UTF8, when they might not be. That's a problem too, but it's still not clear the RightWay to resolve that and likely wouldn't do us any good here in plrust anyways.