Test that Intl.DateTimeFormat canonicalizes the timezones "Etc/GMT", "Etc/UTC", and "GMT" to "UTC" #4328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Etc/UTC", and "GMT" to "UTC"
Ms2ger
approved these changes
Nov 18, 2024
ptomato
reviewed
Dec 4, 2024
| const utcIdentifiers = ["Etc/GMT", "Etc/UTC", "GMT"]; | ||
|
|
||
| for (const timeZone of utcIdentifiers) { | ||
| assert.sameValue(new Intl.DateTimeFormat([], {timeZone}).resolvedOptions().timeZone, "UTC", "Time zone name " + timeZone + " not canonicalized to 'UTC'."); |
There was a problem hiding this comment.
As of the Time Zone Canonicalization proposal which is stage 3, resolvedOptions().timeZone gives the case-regularized original identifier, not the primary identifier. I'll open a PR to fix this.
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Dec 4, 2024
The test for tc39/ecma402#724 (added in tc39#4328) didn't take the Time Zone Canonicalization proposal into account; but it should, because that proposal is stage 3. As of that proposal, the [[TimeZone]] slot of DateTimeFormat gets the case-regularized original identifier, no longer the primary identifier. So the resolvedOptions().timeZone property also no longer returns the primary identifier.
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Jan 16, 2025
The test for tc39/ecma402#724 (added in tc39#4328) didn't take the Time Zone Canonicalization proposal into account; but it should, because that proposal is stage 3. As of that proposal, the [[TimeZone]] slot of DateTimeFormat gets the case-regularized original identifier, no longer the primary identifier. So the resolvedOptions().timeZone property also no longer returns the primary identifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4327