Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Float16 to byteConversionValues #3992

Merged
merged 1 commit into from
Jan 22, 2024
Merged

add Float16 to byteConversionValues #3992

merged 1 commit into from
Jan 22, 2024

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jan 20, 2024

Fixes #3989, cc @iamstolis.

Sidebar: I noticed that the harness files are duplicated under tools/lint/test/fixtures/harness. I didn't update the testTypedArray.js which lives there. Should I? Why are those files duplicated?

@bakkot bakkot requested a review from a team as a code owner January 20, 2024 23:53
@iamstolis
Copy link
Contributor

I have run this revision of test262 tests against graal-js and the tests mentioned in #3989 pass now (and there are no new failures). So, this PR looks good to me. Thanks!

@Ms2ger Ms2ger merged commit 4087779 into main Jan 22, 2024
9 checks passed
@Ms2ger Ms2ger deleted the convert-float16 branch January 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing byteConversionValues.expected.Float16
3 participants