Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce nonClampedIntArrayConstructors #3984

Merged
merged 3 commits into from
Jan 11, 2024
Merged

introduce nonClampedIntArrayConstructors #3984

merged 3 commits into from
Jan 11, 2024

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jan 10, 2024

@bakkot bakkot requested a review from a team as a code owner January 10, 2024 18:58
@bakkot bakkot mentioned this pull request Jan 10, 2024
Merged
@bakkot bakkot changed the title remove Uint8ClampedArray from intArrayConstructors introduce nonClampedIntArrayConstructors Jan 10, 2024
@bakkot bakkot force-pushed the uint8clamped-not-int branch from 6af37cb to 94742e6 Compare January 10, 2024 19:33
@bakkot
Copy link
Contributor Author

bakkot commented Jan 10, 2024

Changed this so that instead intArrayConstructors includes Uint8ClampedArray, and there's a new nonClampedIntArrayConstructors used in the tests which need it per this comment.

(@ljharb's review was for the previous version of this PR, sorry.)

@bakkot bakkot force-pushed the uint8clamped-not-int branch from 94742e6 to 62294b5 Compare January 10, 2024 19:34
ljharb
ljharb approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this better anyways

iamstolis
iamstolis reviewed Jan 10, 2024
View reviewed changes
harness/testTypedArray.js
@@ -20,16 +20,17 @@ var floatArrayConstructors = [
Float32Array
];

var intArrayConstructors = [
var nonClampedIntArrayConstructors = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that nonClampedIntArrayConstructors should be mentioned in the defines list above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, done.

@Ms2ger Ms2ger force-pushed the uint8clamped-not-int branch from 974ee25 to 8b2863f Compare January 11, 2024 10:32
@Ms2ger Ms2ger enabled auto-merge (squash) January 11, 2024 10:33
@Ms2ger Ms2ger merged commit 9c4e0fd into main Jan 11, 2024
9 checks passed
@Ms2ger Ms2ger deleted the uint8clamped-not-int branch January 11, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamstolis iamstolis iamstolis left review comments

@Ms2ger Ms2ger Ms2ger approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bakkot @ljharb @Ms2ger @iamstolis