Add tests for import attributes using with
#3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
force-pushed
the
import-attributes-3
branch
2 times, most recently
from
3ad819f
to
229f2dc
Compare
nicolo-ribaudo
commented
Sep 13, 2023
test/language/module-code/import-attributes/allow-nlt-before-with.js
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,2 @@ | |||
| Make sure to keep the tests in this folder aligned | |||
| with the tests in the import-attributes folder. | |||
There was a problem hiding this comment.
What is the correct way of adding README files?
Linting complains:
/home/circleci/test262/test/language/import/import-assertions/README.md: FRONTMATTER - No valid YAML-formatted frontmatter
/home/circleci/test262/test/language/import/import-assertions/README.md: LICENSE - Invalid Copyright header
Jon4t4n
reviewed
Oct 9, 2023
test/language/module-code/import-attributes/import-attribute-newlines.js
Outdated
Show resolved
Hide resolved
nicolo-ribaudo
force-pushed
the
import-attributes-3
branch
from
1173c01
to
408f5be
Compare
nicolo-ribaudo
force-pushed
the
import-attributes-3
branch
from
408f5be
to
b13654a
Compare
ptomato
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Thanks, and sorry for the long review time.
For future reference it'd be better to squash "Include changes from PR 3932" into "Copy all import assertions tests as a basis for import attributes tests", and the last two commits into "Update import attributes tests to use the with keyword".
In order not to delay this any longer, I'll do the squashing and fix up that one search-replace mistake, and merge it right away.
|
|
||
| // When imported, this file will ensure that a linking error happens by | ||
| // importing a non-existent binding. | ||
| // It can be used to with that there is a linking error, which means |
There was a problem hiding this comment.
Suggested change
| // It can be used to with that there is a linking error, which means | |
| // It can be used to assert that there is a linking error, which means |
ptomato
force-pushed
the
import-attributes-3
branch
from
b13654a
to
f21cae7
Compare
ptomato
force-pushed
the
import-attributes-3
branch
from
f21cae7
to
8693b87
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit just copy-pastes the existing files for
asserttests: when reviewing, you should exclude that commit from the diff (diff of the remaining commits here).If there are comments with suggested changes that would also apply to the
asserttests, I'd prefer to defer resolving them and then I'll open a PR updating both thewithandasserttests at the same time.Closes #3843