Add test for ECMA402 PR 788 #3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
approved these changes
Sep 13, 2023
test/intl402/DateTimeFormat/constructor-invalid-offset-timezone.js
Outdated
Show resolved
Hide resolved
test/intl402/DateTimeFormat/prototype/format/offset-timezone-gmt-same.js
Outdated
Show resolved
Hide resolved
test/intl402/DateTimeFormat/prototype/format/offset-timezone-gmt-same.js
Outdated
Show resolved
Hide resolved
test/intl402/DateTimeFormat/prototype/formatToParts/offset-timezone-correct.js
Outdated
Show resolved
Hide resolved
test/intl402/DateTimeFormat/prototype/resolvedOptions/offset-timezone-change.js
Outdated
Show resolved
Hide resolved
gibson042
reviewed
Sep 13, 2023
test/intl402/DateTimeFormat/prototype/formatToParts/offset-timezone-correct.js
Outdated
Show resolved
Hide resolved
gibson042
reviewed
Sep 13, 2023
test/intl402/DateTimeFormat/prototype/resolvedOptions/offset-timezone-basic.js
Outdated
Show resolved
Hide resolved
gibson042
reviewed
Sep 13, 2023
test/intl402/DateTimeFormat/prototype/resolvedOptions/offset-timezone-change.js
Outdated
Show resolved
Hide resolved
|
thanks for the suggestion. It all make sense. I prefer to keep the test separate for easier debugging and parallize the testing better. |
|
ECMA402 PR 788 reach consensus on 2023-09-26 meeting. Please merge this PR now. |
ptomato
added
has consensus
ptomato
approved these changes
Sep 26, 2023
…imezone-change.js Co-authored-by: Richard Gibson <[email protected]>
…imezone-basic.js Co-authored-by: Richard Gibson <[email protected]>
…ezone-correct.js Co-authored-by: Richard Gibson <[email protected]>
…e.js Co-authored-by: Richard Gibson <[email protected]>
…e.js Co-authored-by: Richard Gibson <[email protected]>
…imezone-change.js Co-authored-by: Richard Gibson <[email protected]>
…e.js Co-authored-by: Richard Gibson <[email protected]>
…mt-same.js Co-authored-by: Richard Gibson <[email protected]>
…mt-same.js Co-authored-by: Richard Gibson <[email protected]>
…ezone-correct.js Co-authored-by: Richard Gibson <[email protected]>
ptomato
force-pushed
the
addOffsetTimeZone
branch
from
bf13ea4
to
b8101b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tc39/ecma402#788
@gibson042 @ben-allen @anba