-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tests for ECMA402 PR811 #3911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests to check the order of option readings and output keys in resolvedOptions of Intl.NumberFormat and PluralRules.
gibson042
requested changes
Sep 12, 2023
test/intl402/NumberFormat/prototype/resolvedOptions/return-keys-order-default.js
Outdated
Show resolved
Hide resolved
Hard code the list of property to be inspect for GetOption Use compareArray
PTAL . Please add label "awaiting specification" |
gibson042
requested changes
Sep 13, 2023
test/intl402/NumberFormat/prototype/resolvedOptions/return-keys-order-default.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Gibson <[email protected]>
Co-authored-by: Richard Gibson <[email protected]>
…s-order-default.js Co-authored-by: Richard Gibson <[email protected]>
gibson042
requested changes
Sep 14, 2023
test/intl402/PluralRules/prototype/resolvedOptions/return-keys-order-default.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Gibson <[email protected]>
Co-authored-by: Richard Gibson <[email protected]>
…efault.js To test all options
gibson042
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
ECMA402 PR811 reach consensus on 2023-09-26 meeting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to check the order of option readings and output keys in resolvedOptions of Intl.NumberFormat and PluralRules.
Test tc39/ecma402#811