Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for ECMA402 PR811 #3911

Merged
merged 10 commits into from
Sep 26, 2023
Merged

Add Tests for ECMA402 PR811 #3911

merged 10 commits into from
Sep 26, 2023

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Sep 9, 2023

Add tests to check the order of option readings and output keys in resolvedOptions of Intl.NumberFormat and PluralRules.

Test tc39/ecma402#811

Add tests to check the order of option readings and output
keys in resolvedOptions of Intl.NumberFormat and PluralRules.
@FrankYFTang FrankYFTang requested a review from a team as a code owner September 9, 2023 04:37
@FrankYFTang
Copy link
Contributor Author

Hard code the list of property to be inspect for GetOption
Use compareArray
@FrankYFTang
Copy link
Contributor Author

PTAL . Please add label "awaiting specification"

Copy link
Contributor

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@FrankYFTang
Copy link
Contributor Author

ECMA402 PR811 reach consensus on 2023-09-26 meeting
Please merge this PR. thanks

@ptomato ptomato merged commit b5fd799 into tc39:main Sep 26, 2023
1 check passed
@FrankYFTang FrankYFTang deleted the addPR811-NFv3Order branch February 22, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants