Various changes to Temporal tests #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
approved these changes
Sep 8, 2023
test/built-ins/Temporal/Duration/prototype/add/relativeto-number.js
Outdated
Show resolved
Hide resolved
ptomato
force-pushed
the
temporal-accumulated-various
branch
2 times, most recently
from
b70546f
to
18ac88f
Compare
Some of these were overlooked in a recent big refactor.
These are also leftovers from the recent refactor, I think.
…Zone This toString() call would observably get the `id` property of the plainDateTime's calendar object. Not good for the tests that I am writing that verify observable calls!
These two can be combined into one test, since they are very similar. This will allow testing the sample DST time zone as well, which is not yet tested.
Just to make sure the time zone arithmetic matches the actual time zone that it is based on.
ptomato
force-pushed
the
temporal-accumulated-various
branch
from
18ac88f
to
e29d7e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not associated with any normative change but are just minor fixes and cleanups that I found while writing new Temporal tests.