Update Intl tests to recognize microsecond and nanosecond as sanctioned #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were added to the list of sanctioned units in a normative change: tc39/ecma402@f627573
trflynn89
force-pushed
the
intl_updates
branch
from
cee8f2b to
23caccf
Compare
ptomato
previously approved these changes
Nov 5, 2022
There was a problem hiding this comment.
Thanks. Both of these changes look correct to me, based on the recent changes. However, it looks like only the microsecond/nanosecond change has been presented. The DurationFormat change looks like it was merged prematurely without TC39 consensus, so I expect it'll be presented at the upcoming November/December meeting.
We can just wait to merge this for a few weeks until that happens, or if you prefer to split the changes up into two PRs, I can merge the microsecond/nanosecond one immediately.
ptomato
added
the
awaiting consensus
trflynn89
force-pushed
the
intl_updates
branch
from
23caccf to
b79f9e2
Compare
trflynn89
changed the title
|
Sure! I changed this PR to only include the microsecond/nanosecond change, and moved the DurationFormat change to #3714. |
ptomato
added
has consensus
ptomato
approved these changes
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were added to the list of sanctioned units in a normative change:
tc39/ecma402@f627573