Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate FinalizationRegistry tests to per-item callback API #2531

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Migrate FinalizationRegistry tests to per-item callback API #2531

merged 1 commit into from
Apr 1, 2020

Conversation

syg
Copy link
Contributor

@syg syg commented Mar 13, 2020 •
edited by rwaldron
Loading

# !! DO NOT MERGE YET !!

This is for the API change proposed in tc39/proposal-weakrefs#187

rwaldron
rwaldron approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@rwaldron rwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes and re-running the CI checks

@rwaldron rwaldron changed the title [DO NOT MERGE] Migrate FinalizationRegistry tests to per-item callback API Migrate FinalizationRegistry tests to per-item callback API Apr 1, 2020
@rwaldron rwaldron merged commit 966fc11 into tc39:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaldron rwaldron rwaldron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syg @rwaldron