Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Nullish Coalesce Expression #2402

Merged
merged 4 commits into from
Oct 10, 2019

Conversation

leobalter
Copy link
Member

FYI, the only error using V8 with the matching flag is due to the lack of support for TCO in a test file that requires it.

test262-harness -t 32 --hostType=d8 --hostPath=v8 --hostArgs='--harmony-nullish' $(git diff --name-only master test/)
FAIL test/language/expressions/coalesce/tco-pos-null.js (strict mode)
  Expected no error, got RangeError: Maximum call stack size exceeded

FAIL test/language/expressions/coalesce/tco-pos-undefined.js (strict mode)
  Expected no error, got RangeError: Maximum call stack size exceeded

Ran 44 tests
42 passed
2 failed

@rwaldron
Copy link
Contributor

This feature is absurd.

@rwaldron rwaldron merged commit f25ae22 into tc39:master Oct 10, 2019
@leobalter leobalter deleted the nullish-coalesce branch October 10, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants