Add cases for Optional Expressions as DestructuringAssignmentTarget #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
reviewed
Aug 5, 2019
| //- elems | ||
| [x?.y = 42] | ||
| //- vals | ||
| [23] |
There was a problem hiding this comment.
what purpose does [23] serve here?
| $DONOTEVALUATE(); | ||
| var x = {}; | ||
| //- elems | ||
| [x?.y] |
There was a problem hiding this comment.
☝️ does [x.y] without a RHS evaluate as a destructuring assignment?
I think I would have assumed that this was an [ Expression ]. Would this production work:
const arr = [x?.y, x?.z];
| set y(val) { | ||
| throw new Test262Error('The property should not be accessed.'); | ||
| } | ||
| }?.y] |
There was a problem hiding this comment.
same question as above, probably me failing to read this production properly.
|
@rkirsling I edited your comment to fix the links |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ljharb @bcoe