Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for String.prototype.replaceAll #2417

Closed
mathiasbynens opened this issue Nov 11, 2019 · 5 comments · Fixed by #2423
Closed

Add tests for String.prototype.replaceAll #2417

mathiasbynens opened this issue Nov 11, 2019 · 5 comments · Fixed by #2423
Assignees

Comments

@mathiasbynens
Copy link
Member

Ref. tc39/proposal-string-replaceall#28

@leobalter
Copy link
Member

Is anyone interesting in picking this up? Otherwise I'll assign it to myself in about an hour.

cc @ljharb

@mathiasbynens
Copy link
Member Author

mathiasbynens commented Nov 12, 2019

I imagine we can mostly duplicate the existing String.prototype.replace tests, modifying those tests where searchValue and replaceValue are both strings. At that point, we’d only have to add tests for the exception on a non-global RegExp searchValue (but again, we can mostly re-use the existing matchAll tests for that).

@leobalter
Copy link
Member

Sure thing, I'm just checking as IIRC, @ljharb has expressed intention to write these tests in the last meeting. Otherwise, I'm gonna get this covered this week. (today or tomorrow, optimistically).

@ljharb
Copy link
Member

ljharb commented Nov 12, 2019

Feel free to do it before i find time to :-)

@leobalter leobalter self-assigned this Nov 12, 2019
@leobalter
Copy link
Member

I imagine we can mostly duplicate the existing String.prototype.replace tests, modifying those tests where searchValue and replaceValue are both strings.

This would be amazing if we didn't have too many legacy tests.

leobalter added a commit to leobalter/test262 that referenced this issue Nov 13, 2019
leobalter added a commit to leobalter/test262 that referenced this issue Nov 13, 2019
leobalter added a commit that referenced this issue Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants