Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ms2ger <[email protected]>
  • Loading branch information
ben-allen and Ms2ger authored Aug 28, 2023
1 parent 49b5e75 commit 786f5e1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,9 @@ info: |
45. If dateTimeFormat.[[Hour]] is undefined, then
a. Set dateTimeFormat.[[HourCycle]] to undefined.
features: [Intl.DateTimeFormat-datetimestyle]
---*/

const hcValues = ["h11", "h12", "h23", "h24"];
const hour12Values = ["h11", "h12"];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ locales.forEach(function(locale){
}

// however, "h24" can be set via locale extension.
if (hcDefault === "h23" || hcDefault === "h24"){
if (hcDefault === "h23" || hcDefault === "h24") {
assert.sameValue(hcDefault, new Intl.DateTimeFormat(locale, {hour: "numeric", hour12: false}).resolvedOptions().hourCycle);
}

Expand Down

0 comments on commit 786f5e1

Please sign in to comment.