Combine Private Fields and Public Fields into one proposal #49
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicoxyzzy
commented
May 26, 2017
README.md
Outdated
| @@ -23,11 +23,10 @@ This list contains only stage 1 proposals and higher that have not yet been with | |||
| | | [`s` (`dotAll`) flag for regular expressions](https://github.com/mathiasbynens/es-regexp-dotall-flag) | Mathias Bynens, Brian Terlson | 3 | | |||
| | | [`function.sent` metaproperty](https://github.com/allenwb/ESideas/blob/master/Generator%20metaproperty.md) | Allen Wirfs-Brock | 2 | | |||
| | | [`String.prototype.{trimStart,trimEnd}`](https://github.com/sebmarkbage/ecmascript-string-left-right-trim) | Sebastian Markbage | 2 | | |||
| | | [Public Class Fields](https://tc39.github.io/proposal-class-public-fields/) | Jeff Morrison | 2 | | |||
| | | [Class Fields](https://github.com/littledan/proposal-class-fields/) | Daniel Ehrenberg | 2 | | |||
There was a problem hiding this comment.
is @jeffmo also champion?
|
It'd be appreciated if only proposal champions made PRs about proposals. |
|
This change is accurate, except you can now link to it as https://github.com/tc39/proposal-class-fields . @ljharb I'd be fine with reviewing PRs from contributors to update this document; just mention me and I'll do the review. |
|
So the two changes needed here are:
|
chicoxyzzy
force-pushed
the
class_fields
branch
2 times, most recently
from
8e22c4b to
c0da439
Compare
|
ljharb
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.