docs: flesh out API and justification for uuid standard library #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctavan
requested changes
Jun 17, 2019
There was a problem hiding this comment.
Awesome, thanks for getting started on this, I think it's a very good starting point!
In my comments I focused on consistency of terminology and formatting. I bet @broofa will have much more elaborate feedback on the proposed contents 😉
Merged
broofa
reviewed
Jun 17, 2019
bcoe
force-pushed
the
start-to-flesh-out-proposal
branch
from
b79540e to
4fbaa13
Compare
ctavan
reviewed
Jun 22, 2019
littledan
reviewed
Jun 23, 2019
ctavan
approved these changes
Jun 23, 2019
bcoe
changed the title
littledan
approved these changes
Jun 24, 2019
broofa
approved these changes
Jun 24, 2019
littledan
reviewed
Jun 25, 2019
littledan
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feeling inspired by TC39, and by the statistics @ctavan pulled together, I've started to flesh out the API for the
uuidbuilt-in module.I've also made an effort to start to outline why I think looking at community practices on npm, and using these to help inspire built-in modules, is valuable.