Editorial: Simplify date/time range validation #2658
Merged
+175
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justingrant
added
non-prod-polyfill
justingrant
force-pushed
the
range-validation-refactor
branch
from
ac60dfc to
f6efff3
Compare
Codecov Report
@@ Coverage Diff @@
## main #2658 +/- ##
==========================================
+ Coverage 96.07% 96.10% +0.02%
==========================================
Files 20 20
Lines 11676 11697 +21
Branches 2203 2186 -17
==========================================
+ Hits 11218 11241 +23
+ Misses 394 392 -2
Partials 64 64
|
gibson042
reviewed
Aug 19, 2023
justingrant
force-pushed
the
range-validation-refactor
branch
4 times, most recently
from
8caefac to
f541879
Compare
|
@gibson042 - I think all your review comments are addressed, want to take another look? Thanks! |
gibson042
reviewed
Aug 20, 2023
gibson042
approved these changes
Aug 20, 2023
justingrant
force-pushed
the
range-validation-refactor
branch
5 times, most recently
from
146f909 to
4f79012
Compare
ptomato
approved these changes
Aug 21, 2023
Removes `!` from calls of IsValidEpochNanoseconds, because that AO is infallible.
justingrant
force-pushed
the
range-validation-refactor
branch
from
4f79012 to
911cf9f
Compare
This commit refactors several operations related to range validation of Temporal.PlainDateTime and Temporal.Instant. * Adds optional _offsetNanoseconds_ parameter to GetUTCEpochNanoseconds, and uses it in call sites of GetUTCEpochNanoseconds where an offset was previously applied to its result. * Makes polyfill GetUTCEpochNanoseconds infallible, like in the spec. * Simplifies the polyfill's GetNamedTimeZoneOffsetNanoseconds by using the now-infallible GetUTCEpochNanoseconds. * Simplifies the polyfill's PlainDateTime range validation in RejectDateTimeRange. * Clarifies the PlainDateTime docs about that type's valid range. * Removes non-parsing logic from ParseTemporalInstantString, aligning Instant parsing with the parsing pattern used in other Temporal types where parsing AOs contain only parsing without interpretation. * Inlines the single-caller ParseTemporalInstant into ToTemporalInstant, matching the pattern used by ToTemporalYearMonth, ToTemporalTime, etc. * Marks ParseDateTimeUTCOffset as infallible after parsing instant strings, because ParseTemporalInstantString guarantees that the offset is valid. Fixes tc39#2637. * Aligns polyfill more closely to spec for Instant parsing.
justingrant
force-pushed
the
range-validation-refactor
branch
from
911cf9f to
a1f2a9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors several operations related to range validation of Temporal.PlainDateTime and Temporal.Instant.
commit 1: remove the
!from existing calls to IsValidEpochNanoseconds which is infallible.commit 2:
year % 400trick to avoid overflows._offsetNanoseconds_parameter to GetUTCEpochNanoseconds, and uses it in call sites of GetUTCEpochNanoseconds where an offset was previously applied to its result.