Normative: change ordering of balancing operations in Temporal.Durati… #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2517 +/- ##
==========================================
- Coverage 95.97% 95.51% -0.46%
==========================================
Files 20 20
Lines 11123 10928 -195
Branches 2126 2033 -93
==========================================
- Hits 10675 10438 -237
- Misses 387 430 +43
+ Partials 61 60 -1
... and 13 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ptomato
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Looks good. I'm glad this bugfix turned out to be so straightforward.
FYI, the process for normative PRs is that I mark this as a draft so that it doesn't get merged accidentally before being presented in the TC39 meeting. Then once it's been approved, I'll un-draft it, and push an update that updates the test262 submodule to include tc39/test262#3793 so that the tests pass.
|
This reached consensus at the March 2023 TC39 meeting. Test262 tests are in tc39/test262#3793. |
…on.prototype.round If we balance the bigger units before the smaller ones, then we never properly balance the days that are added from balancing units up to day length. Changing the order of operations ensures proper balancing of all units. There is also no more need for the call to MoveRelativeZonedDateTime() in the end of the method, so it's been removed. Closes: tc39#2508
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 18, 2023
…poral.Duration.prototype.round. r=spidermonkey-reviewers,mgaudet Implement the changes from <tc39/proposal-temporal#2517>. Depends on D182039 Differential Revision: https://phabricator.services.mozilla.com/D182040
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 19, 2023
…poral.Duration.prototype.round. r=spidermonkey-reviewers,mgaudet Implement the changes from <tc39/proposal-temporal#2517>. Depends on D182039 Differential Revision: https://phabricator.services.mozilla.com/D182040
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jul 21, 2023
…poral.Duration.prototype.round. r=spidermonkey-reviewers,mgaudet Implement the changes from <tc39/proposal-temporal#2517>. Depends on D182039 Differential Revision: https://phabricator.services.mozilla.com/D182040 UltraBlame original commit: 56d3e3e518e00ecc082fd1cd862a1d0ac5cea7af
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jul 21, 2023
…poral.Duration.prototype.round. r=spidermonkey-reviewers,mgaudet Implement the changes from <tc39/proposal-temporal#2517>. Depends on D182039 Differential Revision: https://phabricator.services.mozilla.com/D182040 UltraBlame original commit: 56d3e3e518e00ecc082fd1cd862a1d0ac5cea7af
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jul 21, 2023
…poral.Duration.prototype.round. r=spidermonkey-reviewers,mgaudet Implement the changes from <tc39/proposal-temporal#2517>. Depends on D182039 Differential Revision: https://phabricator.services.mozilla.com/D182040 UltraBlame original commit: 56d3e3e518e00ecc082fd1cd862a1d0ac5cea7af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on.prototype.round
If we balance the bigger units before the smaller ones, then we never properly balance the days that are added from balancing units up to day length. Changing the order of operations ensures proper balancing of all units.
There is also no more need for the call to MoveRelativeZonedDateTime() in the end of the method, so it's been removed.
Closes: #2508