Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Consistent prose for functions and methods #2319

Merged
merged 11 commits into from
Jun 22, 2022

Conversation

ptomato
Copy link
Collaborator

@ptomato ptomato commented Jun 20, 2022

Split out from #2207, this applies the agreed-upon standard wording for functions and methods. (See tc39/ecma262#2304 (comment) and tc39/ecma262#2592)

Closes: #1465

ptomato added 11 commits June 20, 2022 17:08
This is the proposed wording for methods and functions in ECMA-262.

See: #1465
See also: ecma262#2304
This is the proposed wording for methods and functions in ECMA-262.

See: #1465
See also: ecma262#2304
This is the proposed wording for methods and functions in ECMA-262.

See: #1465
See also: ecma262#2304
This is the proposed wording for methods and functions in ECMA-262.

See: #1465
See also: ecma262#2304
…ethods

This is the proposed wording for methods and functions in ECMA-262.

See: #1465
See also: ecma262#2304
…ethods

This is the proposed wording for methods and functions in ECMA-262.

See: #1465
See also: ecma262#2304
This is the proposed wording for methods and functions in ECMA-262.

See: #1465
See also: ecma262#2304
…methods

This is the proposed wording for methods and functions in ECMA-262.

See: #1465
See also: ecma262#2304
This is the proposed wording for methods and functions in ECMA-262.

See: #1465
See also: ecma262#2304
This is the proposed wording for methods and functions in ECMA-262.

See: #1465
See also: ecma262#2304
…ethods

This is the proposed wording for methods and functions in ECMA-262.

See: #1465
See also: ecma262#2304
@ptomato ptomato added spec-text Specification text involved editorial labels Jun 20, 2022
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #2319 (35e1baf) into main (a454134) will increase coverage by 9.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2319      +/-   ##
==========================================
+ Coverage   81.83%   91.08%   +9.25%     
==========================================
  Files          17       19       +2     
  Lines       10547    10566      +19     
  Branches     1478     1695     +217     
==========================================
+ Hits         8631     9624     +993     
+ Misses       1872      932     -940     
+ Partials       44       10      -34     
Flag Coverage Δ
test262 83.94% <ø> (?)
tests 81.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
polyfill/lib/shim.mjs 68.75% <0.00%> (ø)
polyfill/lib/legacydate.mjs 0.00% <0.00%> (ø)
polyfill/lib/intl.mjs 100.00% <0.00%> (+1.58%) ⬆️
polyfill/lib/intrinsicclass.mjs 51.35% <0.00%> (+2.70%) ⬆️
polyfill/lib/calendar.mjs 94.39% <0.00%> (+4.93%) ⬆️
polyfill/lib/ecmascript.mjs 93.33% <0.00%> (+5.92%) ⬆️
polyfill/lib/timezone.mjs 93.63% <0.00%> (+8.28%) ⬆️
polyfill/lib/now.mjs 100.00% <0.00%> (+8.77%) ⬆️
polyfill/lib/duration.mjs 80.61% <0.00%> (+10.67%) ⬆️
polyfill/lib/zoneddatetime.mjs 98.23% <0.00%> (+11.09%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a454134...35e1baf. Read the comment docs.

@Ms2ger Ms2ger merged commit 8c14659 into main Jun 22, 2022
@Ms2ger Ms2ger deleted the 1465-consistent-wording branch June 22, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial spec-text Specification text involved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make introduction paragraph for functions consistent in spec text
3 participants