Allow ISO strings with bracketed time zone and no offset #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it would return an object with 'offset' and 'ianaName' properties and also a 'zone' property which was equal to 'ianaName' if present, and 'offset' if not. This is no longer always the preferred order due to the options in Temporal.ZonedDateTime.from(), so just have it return each property separately if it is present, and implement the preferred order on the caller's end.
The time zone properties are undefined if not present, not null, and the spec also has the calendar field of the record being undefined if not present.
Previously we considered a "time zone part" to be an offset plus an optional bracketed name. Now an ISO string may have either of an "offset part" and "time zone name part", independently of each other. Closes: #933
ptomato
requested review from
Ms2ger,
justingrant,
pipobscure,
jasonwilliams,
sffc,
gibson042,
mattjohnsonpint and
ryzokuken
Codecov Report
@@ Coverage Diff @@
## main #1024 +/- ##
=======================================
Coverage 94.23% 94.24%
=======================================
Files 18 18
Lines 6284 6290 +6
Branches 932 938 +6
=======================================
+ Hits 5922 5928 +6
Misses 355 355
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ms2ger
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #933