Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor as "Stable Formatting" #10

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Refactor as "Stable Formatting" #10

merged 3 commits into from
Sep 8, 2023

Conversation

eemeli
Copy link
Member

@eemeli eemeli commented Sep 2, 2023

Closes #1
Closes #3
Closes #5
Closes #6

Based on comments from @aphillips and @justingrant, it's probably best to call this a "null locale" and use zxx rather than und as its identifier.

After merging, the repo should also be renamed.

@justingrant
Copy link

I think "null locale" is much, much better than "root locale". That said, "null locale" is potentially confused with null (and that's the kind of thing that could lead to long discussion and/or blocking in TG1) so I'd be inclined to continue bikeshedding to see if there's a non-keyword name that could be used instead, like "generic locale".

But changing from root locale to something else is a step in the right direction!

@eemeli eemeli changed the title Refactor as "null locale" Refactor as "Stable Formatting" Sep 7, 2023
@eemeli
Copy link
Member Author

eemeli commented Sep 7, 2023

Ping @zbraniecki, @FrankYFTang, @sffc: This updates the refactor as agreed on the call, and adds a note clarifying that the solution might not lie within Intl.

I'll be renaming the repo as proposal-stable-formatting once this is merged.

README.md Outdated Show resolved Hide resolved
@eemeli eemeli merged commit b1f3d21 into main Sep 8, 2023
@eemeli eemeli deleted the nullify branch September 8, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants