This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FAQ entry on differences between
v
andu
#63Add FAQ entry on differences between
v
andu
#63Changes from 5 commits
95db095
4af6d41
1d59066
e1f1ec6
326c11c
48748ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gibson042 @markusicu @macchiati @pthier Is
/[^^]/v
actually an error? I noticed the current V8 implementation allows it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it isn't, as the first
^
is consumed by the productionCharacterClass :: [ ^ ClassContents ]
, so the remaining^
is not a reserved double punctuator.[^^^]
is an error in V8.Note that also
[]]
is not a breaking change, as this is an error also with/u
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess
[_^^]
or, indeed,[^^^]
is a better example. I’ll change this. Thanks![]]
is currently not listed as a breaking change, so I think there’s no action to be taken for that one. Let me know if I misunderstood.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR: #74