Rename to "Module Declarations" and update readme #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering if we can merge those two proposals into one. |
littledan
approved these changes
Nov 2, 2022
|
|
||
| ### Does this proposal work with import maps? | ||
|
|
||
| [Import maps](https://github.com/WICG/import-maps) can be used in conjunction with module fragments, in that the import map can redirect bare specifiers to be found in module fragments, rather than independent fetches. Mechanically: The lookup in the import map (which is done as part of "resolving a module specifier") precedes the interpretation of fragments in the module specifier (which are treated as part of the module map key). (TODO: add example of use together.) | ||
| [Import maps](https://github.com/WICG/import-maps) can be used in conjunction with module declarations, in that the import map can redirect bare specifiers to be found in module declarations, rather than independent fetches. Mechanically: The lookup in the import map (which is done as part of "resolving a module specifier") precedes the interpretation of declarations in the module specifier (which are treated as part of the module map key). (TODO: add example of use together.) |
There was a problem hiding this comment.
Note, this part doesn't really apply anymore without import map extensions; we should track that in an issue.
There was a problem hiding this comment.
I commented this section out for now, and renamed #10 to include "import maps" in the title (since it's effectively what that issue is about).
|
@Jack-Works I prefer to leave them separate for now, as module expressions is a much simpler proposal and works on its own and so would come first. They are designed to compose well; I am glad that we have this design fully sketched out. |
nicolo-ribaudo
force-pushed
the
update-readme-rename-proposal
branch
4 times, most recently
from
f50adae to
ab40a61
Compare
nicolo-ribaudo
force-pushed
the
update-readme-rename-proposal
branch
from
ce3c9d6 to
6c1bc6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is parallel to tc39/proposal-module-expressions#77: the two proposals are now named "Module Expressions" and "Module Declarations", to better explain their relationship and their differences.