This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
fixes #229: flatMap supports returning both iterables and iterators #233
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cd906f0
fixes #229: flatMap supports returning both iterables and iterators
michaelficarra 7f36844
only CreateAsyncFromSyncIterator when necessary
michaelficarra 57725e3
update
michaelficarra a808e48
accidentally dropped the fast path
michaelficarra 267fa97
fix editorial issues
michaelficarra 938a6a0
oops, async
michaelficarra 390def7
Merge branch 'main' into GH-229
michaelficarra c94e37a
Merge branch 'main' into GH-229
michaelficarra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this variable name is confusing, since
_iterator_
isn't already async here, it just shouldn't be made async later (if i'm understanding right)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only applicable in the
_hint_ is ~async~
path. The iterator is assumed to be async if we're trying to get an async iterator. I could have guarded this assignment for clarity, but it wouldn't change the result.