-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should %Segments% instances have a link back to their Intl.Segmenter? #96
Comments
LGTM |
No particular concerns, but it also doesn't sound so bad to have to pass the segmenter around. |
Options for avoiding the "exotic internal slot" hazard:
I don't like option 3 or 4 because they strip out too much from a Segments instance, and option 3 in particular is distasteful because having the string without the segmenter excessively limits what can be done with it. Option 2 can work but seems out of place. I personally favor option 1, in line with the decision from tc39/proposal-promise-any#38 . |
I prefer to wait for the broader discussion as suggested by @littledan before we try to reach consensus on any of the proposed options. |
Resolved in today's ECMA-402 call to sidestep the concern by removing both |
In the July 16th SES call, @erights and I arrived at the conclusion that there is no need to avoid internal slots in cases like Intl.Segmenter and Temporal classes, where
If the change in #117 is justified by other aspects of good design, I'm fine with this decision . I don't think we should consider the "exotic internal slot hazard" a reason to make API design decisions, though. |
It could be useful for e.g. iteration from an arbitrary point.
The text was updated successfully, but these errors were encountered: